Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show inline notifications for public profile #952

Merged
merged 2 commits into from
Mar 17, 2025
Merged

fix: show inline notifications for public profile #952

merged 2 commits into from
Mar 17, 2025

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Mar 3, 2025

ref #819

@pyphilia pyphilia requested a review from spaenleh March 3, 2025 10:26
@pyphilia pyphilia self-assigned this Mar 3, 2025
@pyphilia pyphilia marked this pull request as ready for review March 5, 2025 08:14
spaenleh
spaenleh approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! 🪡

@pyphilia pyphilia force-pushed the 819-public-profile-notification branch from 933ec43 to 640e987 Compare March 17, 2025 07:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@spaenleh
Copy link
Member

@pyphilia I took the liberty to fix the CI install process according to the issue between pnpm dlx and pnpm exec for playwright

ref: https://github.com/orgs/pnpm/discussions/5820

@pyphilia pyphilia merged commit 867e558 into main Mar 17, 2025
5 checks passed
@pyphilia pyphilia deleted the 819-public-profile-notification branch March 17, 2025 08:56
@graasper graasper mentioned this pull request Mar 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
un-released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyphilia @spaenleh