Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to delete bookmarks on home #953

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Mar 3, 2025

Screen.Recording.2025-03-03.at.12.14.30.mov

TODO:

  • write tests

close #922

@pyphilia pyphilia requested a review from spaenleh March 3, 2025 11:15
@pyphilia pyphilia self-assigned this Mar 3, 2025
@spaenleh
Copy link
Member

spaenleh commented Mar 7, 2025

Note

I haven't looked at the code yet, so this is just a comment on aesthetics from watching the recording.

Since the only actions that the user can perform in this new "modify" view is to remove bookmarks, maybe the removal button should more clearly communicate that it will remove the whole card by placing it on the corner of the card.

Also I think the choice of the "X" icon and the "back" text did not resonate with me, I was not sure what they would do.

Below you can find a screenshot with suggestions that I think could improve the the understanding of the feature by basing they on common interactions in the digital world. Let me know what you think.

I like the choice of red for the deletion icon, and the rest of the interaction and button placement is 👌 .

suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bookmarks management (title, delete)
2 participants