Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update install docs #39

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix: update install docs #39

merged 2 commits into from
Feb 28, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Feb 28, 2024 •
edited
Loading

In this PR I try to improve the documentation of the getting started guide.

  • added mention of volta
  • added more detailed instructions for env variables
  • added mention of storybook as a dev tool

@spaenleh spaenleh self-assigned this Feb 28, 2024
@spaenleh spaenleh added the documentation Improvements or additions to documentation label Feb 28, 2024
swouf
swouf requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@swouf swouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I just have a few minor comments but I'll approve once you have seen them.

@swouf swouf self-assigned this Feb 28, 2024
@spaenleh
Copy link
Member Author

@swouf Thank you for the review, I made the changes you requested. Thank you for the suggestions !

@spaenleh spaenleh requested a review from swouf February 28, 2024 13:10
swouf
swouf approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@swouf swouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spaenleh spaenleh merged commit 15b5b88 into main Feb 28, 2024
2 checks passed
@spaenleh spaenleh deleted the update-install-docs branch March 5, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swouf swouf swouf approved these changes

@juancarlosfarah juancarlosfarah Awaiting requested review from juancarlosfarah

Assignees

@swouf swouf

@spaenleh spaenleh

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaenleh @swouf