-
Notifications
You must be signed in to change notification settings - Fork 56
[newchem-cpp] lookup_cool_rate1d cleanup part 2
#416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brittonsmith
merged 22 commits into
grackle-project:newchem-cpp
from
mabruzzo:ncc/lookup_rate_1d_cleanup-scratch
Nov 18, 2025
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
66c4cb9
ground work for h2dust_grain_interp_props
mabruzzo 0031dcf
switch to using h2dust_grain_interp_props
mabruzzo 592dc98
perform a little cleanup
mabruzzo a462034
incremental commit
mabruzzo acc4b15
start using ShieldFactorCalculator
mabruzzo 25b447f
create apply_misc_shield_factors (but do not use it yet)
mabruzzo 1c50b0d
finish transition to using apply_misc_shield_factors
mabruzzo 13177ce
apply clang-format
mabruzzo 0050278
Merge branch 'ncc/lookup_rate_1d_cleanup-interp' into ncc/lookup_rate…
mabruzzo 56e69fd
add a clarifying comment
mabruzzo c10c89d
Stop allocating memory on each call to lookup_cool_rates1d
mabruzzo 0c49e8a
minor bugfix
mabruzzo f487efe
intermediate commit
mabruzzo e34e616
factor out model_H2I_dissociation_shielding
mabruzzo 0fe3706
do a little cleanup
mabruzzo 79e8668
apply formatting
mabruzzo 9cdc48b
Merge branch 'ncc/lookup_rate_1d_cleanup-interp' into ncc/lookup_rate…
mabruzzo 369f7ba
Merge branch 'ncc/lookup_rate_1d_cleanup-interp' into ncc/lookup_rate…
mabruzzo f7617fa
Merge branch 'ncc/lookup_rate_1d_cleanup-interp' into ncc/lookup_rate…
mabruzzo 619288f
Merge branch 'ncc/lookup_rate_1d_cleanup-interp' into ncc/lookup_rate…
mabruzzo 4101578
Merge branch 'ncc/lookup_rate_1d_cleanup-interp' into ncc/lookup_rate…
mabruzzo b70a4a6
address clang-tidy warning
mabruzzo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe now is the time to right this wrong convert S to Si to denote this being silicon.