[newchem-cpp] transcribe of cool1d_cloudy_old_tables_g (NEW) #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherBignamini
changed the title
ChristopherBignamini
changed the title
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…kle::impl::fortran_wrappee namespace versions
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…transcribe_cool1D_cloudy_old_tables_g_new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brittonsmith @mabruzzo this PR overwrites #445: I made a mistake in the old PR by starting from the wrong branch to do the transcription and then I also added some bugs that result in wrong numerical results. This PR is equivalent but cleaner. @mabruzzo I just saw your comment in the old PR, I will implement here the requested changes.