remote.vault: enhance auth.custom to support namespace switching for authentication #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with Vault Enterprise it is possible to define Namespace and secure multi-tenancy. This means one can create multiple namespaces while maintaining a single Vault instance. Furthermore, it is possible to separate the authentication namespace from the kv namespace. For example it is possible to authenticate against "ns1/" while the secret kv's exist under "ns1/childns1". Currently, Alloy does not support switching between namespaces while authenticating versus retrieving the kv secrets. This commit addresses that limitation.
Notedop
force-pushed
the
notedop/support_vault_ent_namespace_switching
branch
from
b89e79a to
9f88ccc
Compare
|
Rebased on latest main branch to address conflict in |
|
@clayton-cornell could you review this PR for me and let me know if this is fine? |
Rephrased documentation by code reviewer Co-authored-by: Clayton Cornell <[email protected]>
|
@clayton-cornell thank you for the review. I've committed your suggestions. |
|
Now over to @grafana/grafana-agent-maintainers for a code review |
clayton-cornell
added
the
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
With Vault Enterprise it is possible to define different namespaces and multi-tenancy support as described here. With this setup it is also possible to have a dedicated authentication namespace, while the kv store exists on a child namespace.
Currently Alloy uses the same client for both the AuthenticationManager and SecretManager; as a result currently it is not possible to define a separate namespace for each client.
This PR addresses the above and will allow you to override the namespace used by the client of the authentication manager.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist