Enforces string type #2959
Open
Enforces string type #2959
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you pass --set "alloy.extraEnv[0].value=8443", Helm interprets 8443 as a number, which is incompatible with a template expecting a string.
|
|
thampiotr
requested changes
Mar 12, 2025
Comment on lines
+35
to
+37
| {{- range $envValue := $values.extraEnv }} | ||
| - name: {{ $envValue.name | quote }} | ||
| value: {{ $envValue.value | quote }} |
There was a problem hiding this comment.
This will not work with other valid ways to specify extraEnv like
- name: ...
valueFrom: ...
So we cannot 'fix' it this way. Instead please open an issue where you provide a bit more detail on the use case and the command that you execute that is not working for you, we may be able to help with finding a solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you pass --set "alloy.extraEnv[0].value=8443", Helm interprets 8443 as a number, which is incompatible with a template expecting a string.
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist