Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions workflows added #445

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yesoreyeram
Copy link
Collaborator

@yesoreyeram yesoreyeram commented Jan 11, 2025

@yesoreyeram yesoreyeram self-assigned this Jan 11, 2025
@yesoreyeram yesoreyeram marked this pull request as ready for review January 11, 2025 09:20
@yesoreyeram yesoreyeram requested a review from a team as a code owner January 11, 2025 09:20
@zoltanbedi
Copy link
Member

@yesoreyeram should @gwdawson do this?

@yesoreyeram
Copy link
Collaborator Author

yea.. leaving this for Gareth.

Copy link
Member

@gwdawson gwdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +7 to +9
pull_request:
branches:
- main
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pull_request:
branches:
- main
pull_request:

Comment on lines +15 to +16
with:
plugin-version-suffix: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || '' }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with:
plugin-version-suffix: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || '' }}
with:
go-version: '1.23.5'
plugin-version-suffix: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || '' }}

Comment on lines +27 to +28
with:
branch: ${{ github.event.inputs.branch }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with:
branch: ${{ github.event.inputs.branch }}
with:
go-version: '1.23.5'
branch: ${{ github.event.inputs.branch }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants