Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data links: Show oneClick option just for specific panels #100298

Merged
merged 27 commits into from
Feb 12, 2025

Conversation

adela-almasan
Copy link
Contributor

@adela-almasan adela-almasan commented Feb 7, 2025

This PR hides the one-click option from certain panels AND defaults to hide actions from default options and show them just for certain panels.
Supported panels: Canvas, Timeseries, Candlestick, Trend, XY Chart, Bar chart, State timeline, Status history

Fixes #97605
Dependent on #100097

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@adela-almasan adela-almasan added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Feb 7, 2025
@adela-almasan adela-almasan self-assigned this Feb 7, 2025
@adela-almasan adela-almasan requested review from grafanabot and a team as code owners February 7, 2025 16:35
@adela-almasan adela-almasan requested review from Develer, drew08t, ivanortegaalba, mdvictor, tskarhed, ashharrison90 and mckn and removed request for a team February 7, 2025 16:35
@github-actions github-actions bot added this to the 11.6.x milestone Feb 7, 2025
Base automatically changed from adela/data_links_components_refactor to main February 8, 2025 02:03
@grafana-pr-automation grafana-pr-automation bot added the area/panel/canvas Issues related to canvas panel label Feb 11, 2025
showOneClick: false,
},
},
[FieldConfigProperty.Actions]: {
hideFromDefaults: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed any more, but we'll need to flip this to false in next PR that adds support

@adela-almasan adela-almasan merged commit 3dcd885 into main Feb 12, 2025
18 checks passed
@adela-almasan adela-almasan deleted the adela/hide_datalinks_oneclick branch February 12, 2025 22:14
baldm0mma pushed a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataLinks: Show one-click option only for uPlot panels
2 participants