This repository was archived by the owner on Aug 30, 2021. It is now read-only.
* Changed the plugin to take an interval for a sampling aggregator ra… #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsabin
commented
Nov 13, 2018
jsabin
commented
- Alphabetized the aggregators list.
- Fixed the legacy target converted to use the interval for a sampling aggregator.
- Fixed the legacy target converter to not set the unit for the percentile aggregator.
- All variables are now resolved, not just the metric name.
- Fixed a bug where options was not available sometimes when metricFindQuery() is called.
- Fixed bug where a metric only has one tag value for a given tag but there are data points without the tag value. The UI would not let you select the tag. This was also confusing for a single-valued tag because it looked like the tag value was selected but it was not.
- If you add 2 or more aggregators to a Grafana panel, delete the first, the other will show it as having the interval and alignment from the first aggregator rather than the one you just entered. The fix is to directly call the getVisibleParameters() method from the controller. I believe this was not working because the UI was not refreshing the controller state ($scope.apply() not being called).
…ther thanusing a separate drop-down for the value and the unit. * Alphabetized the aggregators list. * Fixed the legacy target converted to use the interval for a sampling aggregator. * Fixed the legacy target converter to not set the unit for the percentile aggregator. * All variables are now resolved, not just the metric name. * Fixed a bug where options was not available sometimes when metricFindQuery() is called. * Fixed bug where a metric only has one tag value for a given tag but there are data points without the tag value. The UI would not let you select the tag. This was also confusing for a single valued tag because it looked like the tag value was selected but it was not. * If you add 2 or more aggregators to a Grafana panel, delete the first, the other will show it as having the interval and alignment from the first aggregator rather than the one you just entered. The fix is to directly call the getVisibleParameters() method from the controller. I believe this was not working because the UI was not refreshing the controller state ($scope.apply() not being called).
Implemented Backend Plugin
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.