-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Getting started rewrite #16497
base: main
Are you sure you want to change the base?
Conversation
💻 Deploy preview available:
|
@JStickler, for some reason, the tests keep failing on this one. We are ready for review, happy to discuss these changes on our call together as it was quite a big change to the getting started guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only made it through the docs before I ran out of time. I'll look at the KillerCoda tomorrow.
Co-authored-by: J Stickler <[email protected]> Signed-off-by: Jay Clifford <[email protected]>
Aaah thanks @JStickler! All changes are accepted, and the killercoda has been updated for your testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it through both the docs/local install and the Killercoda today.
Co-authored-by: J Stickler <[email protected]> Signed-off-by: Jay Clifford <[email protected]>
Co-authored-by: J Stickler <[email protected]> Signed-off-by: Jay Clifford <[email protected]>
Hey @JStickler, just accepted your amendments. Will work through the rest manually :) |
What this PR does / why we need it:
With the focus change to two deployment modes, Monolthic and Microservice, it was time to refresh the quick start guide to Loki. This incorporates much of the same flavour as the original:
But includes newer features:
Aswell as adding the Carnivouse Greehouse example to provide an interactive method to understanding LogQL queries.
Killercoda sample found here: https://killercoda.com/grafana-dev-testing/course/workshops/course-tracker-test
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR