chore(dataobj): Wire dataset.Reader into dataobj.LogsReader and dataobj.StreamsReader #16701
+525
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotPredicate is used by dataobj.LogsReader and dataobj.StreamsReader and needed an equivalent in dataset. FalsePredicate is used when no matching column can be found; eliminating the entire dataset.
rfratto
force-pushed
the
wiring-dataset-reader
branch
from
ddc9c6c to
46c3a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the implementation of dataobj.LogsReader and dataobj.StreamsReader to internally use dataset.Reader, which supports predicate pushdown to avoid unnecessary page downloads.
This is still a WIP; some tests aren't passing yet.