Skip to content

feat(helm): Bump sidecar to latest version and /tmp volumeMount #19759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −8
Open

feat(helm): Bump sidecar to latest version and /tmp volumeMount #19759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/sources/setup/install/helm/reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12294,7 +12294,7 @@ false
<td>string</td>
<td>Docker image tag</td>
<td><pre lang="json">
"1.30.10"
"2.1.2"
</pre>
</td>
</tr>
Expand Down
1 change: 1 addition & 0 deletions production/helm/loki/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Entries should include a reference to the pull request that introduced the chang

## Unreleased

- [FEATURE] Bump sidecar to 2.1.2, and add the now mandatory /tmp volumeMount. [#19759](https://github.com/grafana/loki/pull/19759)

## 6.46.0

Expand Down
8 changes: 6 additions & 2 deletions production/helm/loki/templates/backend/statefulset-backend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,9 @@ spec:
volumeMounts:
- name: sc-rules-volume
mountPath: {{ .Values.sidecar.rules.folder | quote }}
{{- end}}
- name: sc-rules-tmp
mountPath: /tmp
{{- end }}
{{- with .Values.backend.extraContainers }}
{{- toYaml . | nindent 8}}
{{- end }}
Expand Down Expand Up @@ -270,7 +272,9 @@ spec:
sizeLimit: {{ .Values.sidecar.rules.sizeLimit }}
{{- else }}
emptyDir: {}
{{- end -}}
{{- end }}
- name: sc-rules-tmp
emptyDir: {}
{{- end -}}
{{- with (concat .Values.global.extraVolumes .Values.backend.extraVolumes) | uniq }}
{{- toYaml . | nindent 8 }}
Expand Down
8 changes: 6 additions & 2 deletions production/helm/loki/templates/ruler/statefulset-ruler.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,9 @@ spec:
volumeMounts:
- name: sc-rules-volume
mountPath: {{ .Values.sidecar.rules.folder | quote }}
{{- end}}
- name: sc-rules-tmp
mountPath: /tmp
{{- end }}
{{- with .Values.ruler.extraContainers }}
{{- toYaml . | nindent 8}}
{{- end }}
Expand Down Expand Up @@ -234,7 +236,9 @@ spec:
sizeLimit: {{ .Values.sidecar.rules.sizeLimit }}
{{- else }}
emptyDir: {}
{{- end -}}
{{- end }}
- name: sc-rules-tmp
emptyDir: {}
{{- end -}}
{{- range $dir, $_ := .Values.ruler.directories }}
- name: {{ include "loki.rulerRulesDirName" $dir }}
Expand Down
8 changes: 6 additions & 2 deletions production/helm/loki/templates/single-binary/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,9 @@ spec:
volumeMounts:
- name: sc-rules-volume
mountPath: {{ .Values.sidecar.rules.folder | quote }}
{{- end}}
- name: sc-rules-tmp
mountPath: /tmp
{{- end }}
{{- with .Values.singleBinary.extraContainers }}
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down Expand Up @@ -272,7 +274,9 @@ spec:
sizeLimit: {{ .Values.sidecar.rules.sizeLimit }}
{{- else }}
emptyDir: {}
{{- end -}}
{{- end }}
- name: sc-rules-tmp
emptyDir: {}
{{- end -}}
{{- with .Values.singleBinary.extraVolumes }}
{{- toYaml . | nindent 8 }}
Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4000,7 +4000,7 @@ sidecar:
# -- The Docker registry and image for the k8s sidecar
repository: docker.io/kiwigrid/k8s-sidecar
# -- Docker image tag
tag: 1.30.10
tag: 2.1.2
# -- Docker image sha. If empty, no sha will be used
sha: ""
# -- Docker image pull policy
Expand Down
Loading