fix: handle INIT from frontend in running scheduler which is not in shouldRun state
#19866
+61
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We expirience the situation where the scheduler is not yet in a "shouldRun" state but receives an init message from the frontend.
In this case the scheduler will not reply with an
OKbut rather will just wait for the next messageThis means the frontend worker is then blocked as it waits for any kind of reply from the scheduler.
Therefore the frontend worker connects to the scheduler but does not forward incoming queries
Which issue(s) this PR fixes:
Fixes #19528
This PR mitigates this issue by sending as the scheduler now sends an
ERRORin case it's RUNNING but shouldRun is still falseThis PR is the "smaller" version of this PR as I hope its easier to review while the other one also add an additional timeout on the frontend side
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR