fix(operator): Return quickstart script to working condition and improve rootless usage #19960
+11,457
−3,275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperimental
requested review from
a team,
JoaoBraveCoding and
periklis
as code owners
operator/quickstart.sh
Outdated
| check() { | ||
| # shellcheck disable=SC2154 | ||
| ${LOGCLI} --addr "http://localhost/token-refresher/api/logs/v1/test-oidc" labels | ||
| ${LOGCLI} --addr "http://localhost:8080/token-refresher/api/logs/v1/test-oidc" labels |
Collaborator
There was a problem hiding this comment.
Seems like logcli is no longer in .bingo maybe I've removed it in one of the cleanups
Collaborator
Author
There was a problem hiding this comment.
I don't think it ever was in bingo, it's much easier to just compile from the ../cmd/logcli/ package when you already have the repository checked out. Currently I have just set this env var when running the script LOGCLI=logcli ./quickstart.sh check ... but that admittedly is not very convenient. Should we just replace it with logcli and expect people to have some kind of logcli installed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
make quickstartwill try to build&push an image and updates the instructions accordinglyWhich issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)