Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependencies and repair checks #1998

Closed
wants to merge 5 commits into from

Conversation

darrenjaneczek
Copy link
Collaborator

@darrenjaneczek darrenjaneczek commented Jul 14, 2023

Goal is to update dependencies as an initial flush out of security concerns

  • example projects:

    • treated as stand-alone and retain yarn.lock files
    • removed package lock files
  • removed yarn.lock files from workspace sub packages

  • Progress toward Sort out NPM dependencies #2000

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Flamegraph.com report

pyroscope-oss.alloc_objects.json
See in flamegraph.com
pyroscope-oss.alloc_space.json
See in flamegraph.com
pyroscope-oss.cpu.json
See in flamegraph.com
pyroscope-oss.goroutines.json
See in flamegraph.com
pyroscope-oss.inuse_objects.json
See in flamegraph.com
pyroscope-oss.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@darrenjaneczek darrenjaneczek force-pushed the chore/security-fix-dependencies branch from 4bf0001 to 009a6f4 Compare July 14, 2023 16:15
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Flamegraph.com report

pyroscope-oss.frontend.cpu.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_objects.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #1998 (7b5b254) into main (daa32a5) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1998      +/-   ##
==========================================
+ Coverage   60.43%   60.49%   +0.06%     
==========================================
  Files         177      177              
  Lines        4999     5007       +8     
  Branches     1158     1156       -2     
==========================================
+ Hits         3021     3029       +8     
  Misses       1966     1966              
  Partials       12       12              
Impacted Files Coverage Δ
packages/pyroscope-models/src/units.ts 100.00% <ø> (ø)
webapp/javascript/ui/Input.tsx 100.00% <ø> (ø)
packages/pyroscope-models/src/spyName.ts 100.00% <100.00%> (ø)

... and 48 files with indirect coverage changes

@darrenjaneczek darrenjaneczek force-pushed the chore/security-fix-dependencies branch from 009a6f4 to 6835fa6 Compare July 14, 2023 16:19
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 1003.66 KB (+0.52% 🔺) 20.1 s (+0.52% 🔺) 903 ms (-79.34% 🔽) 21 s
webapp/public/assets/app.css 19.83 KB (-0.39% 🔽) 397 ms (-0.39% 🔽) 0 ms (+100% 🔺) 397 ms
webapp/public/assets/styles.css 9.53 KB (-0.68% 🔽) 191 ms (-0.68% 🔽) 0 ms (+100% 🔺) 191 ms
packages/pyroscope-flamegraph/dist/index.js 626.63 KB (+0.15% 🔺) 12.6 s (+0.15% 🔺) 459 ms (-82.17% 🔽) 13 s
packages/pyroscope-flamegraph/dist/index.node.js 627.36 KB (+0.15% 🔺) 12.6 s (+0.15% 🔺) 220 ms (-79.84% 🔽) 12.8 s
packages/pyroscope-flamegraph/dist/index.css 8.12 KB (-0.26% 🔽) 163 ms (-0.26% 🔽) 0 ms (+100% 🔺) 163 ms

@darrenjaneczek darrenjaneczek changed the title fix: update and/or remove dependency lock files fix: update dependencies and repair checks Jul 14, 2023
Comment on lines -148 to +163
{!exemplarsSingleView.selectionProfile && exemplarsSingleView.heatmap && (
<Box>
<div className={styles.heatmapSelectionGuide}>
<StatusMessage
type="info"
message="Select an area in the heatmap to get started"
/>
<img
className={styles.gif}
src={heatmapSelectionPreviewGif}
alt="heatmap-selection-gif"
/>
</div>
</Box>
)}
{!exemplarsSingleView.selectionProfile &&
exemplarsSingleView.heatmap && (
<Box>
<div className={styles.heatmapSelectionGuide}>
<StatusMessage
type="info"
message="Select an area in the heatmap to get started"
/>
<img
className={styles.gif}
src={heatmapSelectionPreviewGif}
alt="heatmap-selection-gif"
/>
</div>
</Box>
)}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example of a formatting fix; no functionality changed.

@darrenjaneczek darrenjaneczek marked this pull request as ready for review July 14, 2023 18:01
- type checking issues

- format correction

- protobufjs, lerna dependencies, d3-color, etc.
@darrenjaneczek darrenjaneczek force-pushed the chore/security-fix-dependencies branch from 612b501 to 9f85b9b Compare July 14, 2023 18:45
@darrenjaneczek darrenjaneczek marked this pull request as draft July 14, 2023 20:31
@darrenjaneczek
Copy link
Collaborator Author

This branch has issues that break the build. It did too much at once.
I will likely start over one dependency at a time.

@marcsanmi marcsanmi deleted the chore/security-fix-dependencies branch December 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants