Usage group support for ingestion limits #3914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-p
force-pushed
the
ingestion-limits-usage-groups
branch
from
91553fd to
ed98441
Compare
aleks-p
commented
Feb 13, 2025
Comment on lines
+183
to
+195
| matched := false | ||
| for _, lbl := range lbls { | ||
| if lbl.Name == m.Name && !m.Matches(lbl.Value) { | ||
| return false | ||
| if lbl.Name == m.Name { | ||
| if !m.Matches(lbl.Value) { | ||
| return false | ||
| } | ||
| matched = true | ||
| break | ||
| } | ||
| } | ||
| if !matched { | ||
| return false | ||
| } |
There was a problem hiding this comment.
Unrelated to this PR, but when the request and usage group labels are disjoint, we report this as a match. This change makes sure we have a match on all usage group labels.
shelldandy
pushed a commit
to shelldandy/pyroscope
that referenced
this pull request
Mar 14, 2025
* Apply ingestion limits to usage groups * Check actual usage groups in the request * Make test more robust * Fix case where usage groups can match against a disjoint set of request labels * Reduce nesting in checkUsageGroupsIngestLimit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3879, adding support for reacting to externally configured ingestion limits for usage groups. The config model is extended from before:
When the limit is reached, we add the usage group to the error response:
Usage groups use the global (tenant-level) period type and sampling config for simplicity, this might change in the future if needed.