-
Notifications
You must be signed in to change notification settings - Fork 696
feat(v2): cancel artificial delay on async ingest #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # pkg/distributor/distributor.go # pkg/distributor/writepath/router.go # pkg/distributor/writepath/write_path_test.go
This reverts commit afce63c.
57c5108
to
26d57a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. I tested it manually as well and it worked as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pkg/distributor/distributor.go
Outdated
} | ||
|
||
func isAlloyEBPFRequest(series *distributormodel.PushRequest) bool { | ||
for _, s := range series.Series { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth having a quick path for returning false
, when the request did not come in with a pushv1
.
Otherwise, the client experiences latency despite the async ingest option, making it useless