Skip to content

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Jun 18, 2025

Otherwise, the client experiences latency despite the async ingest option, making it useless

@kolesnikovae kolesnikovae changed the title feat(v2): request level write path overrides feat(v2): cancel artificial delay on async ingest Jun 24, 2025
@kolesnikovae kolesnikovae marked this pull request as ready for review June 24, 2025 11:04
@kolesnikovae kolesnikovae requested review from a team, aleks-p and alsoba13 as code owners June 24, 2025 11:04
@simonswine simonswine self-assigned this Jul 11, 2025
@aleks-p aleks-p force-pushed the feat/request-level-write-path-overrides branch from 57c5108 to 26d57a2 Compare October 16, 2025 16:46
Copy link
Contributor

@aleks-p aleks-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I tested it manually as well and it worked as expected.

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

func isAlloyEBPFRequest(series *distributormodel.PushRequest) bool {
for _, s := range series.Series {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth having a quick path for returning false, when the request did not come in with a pushv1.

@aleks-p aleks-p merged commit 2a57435 into main Oct 16, 2025
28 of 29 checks passed
@aleks-p aleks-p deleted the feat/request-level-write-path-overrides branch October 16, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants