Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SceneDataTransformer: Interpolate transformation options #1051

Merged
merged 4 commits into from
Feb 10, 2025
Merged

SceneDataTransformer: Interpolate transformation options #1051

merged 4 commits into from
Feb 10, 2025

Conversation

dprokop
Copy link
Member

@dprokop dprokop commented Feb 7, 2025 •
edited by scenes-repo-bot-access-token bot
Loading

This make transformation options interpolated prior executing the operators. Thanks to this any transformation can now support variables.

Ref: grafana/grafana#100225 (comment)

TODO:

  • Add test
📦 Published PR as canary version: 6.0.1--canary.1051.13244720070.0

✨ Test out this PR locally via:

npm install @grafana/[email protected]
npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]
yarn add @grafana/[email protected]

@dprokop dprokop added patch Increment the patch version when merged release Create a release when this pr is merged labels Feb 7, 2025
@dprokop dprokop mentioned this pull request Feb 7, 2025
Merged
@dprokop dprokop requested a review from leeoniya February 7, 2025 11:53
@dprokop dprokop requested review from torkelo and leeoniya February 10, 2025 15:39
@dprokop
Copy link
Member Author

dprokop commented Feb 10, 2025

Guess it's ready to land now with tests and this small optimisations?

leeoniya
leeoniya approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@leeoniya leeoniya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dprokop dprokop merged commit 30ae2ca into main Feb 10, 2025
5 checks passed
@dprokop dprokop deleted the transformer-interpolation branch February 10, 2025 15:57
@scenes-repo-bot-access-token
Copy link

🚀 PR was released in v6.0.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo torkelo approved these changes

@leeoniya leeoniya leeoniya approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprokop @torkelo @leeoniya