feat: add frequency and timeout to checkInfo and thus logs #1442
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheckInfo holds metadata about a check, which is added to log lines related to that check. It is useful to find logs for a given check ID, or to trace the check that yielded a particularly interesting log line. We suspect that some frequency/timeout combinations are problematic, specifically where those values are too close. By adding them to this logged metadata, we may be able to spot if problematic log lines are due to these combinations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CheckInfo holds metadata about a check, which is added to log lines related to that check. It is useful to find logs for a given check ID, or to trace the check that yielded a particularly interesting log line.
We suspect that some frequency/timeout combinations are problematic, specifically where those values are too close. By adding them to this logged metadata, we may be able to spot if problematic log lines are due to these combinations.