Update Readme #75
Closed
Update Readme #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkel
reviewed
Dec 5, 2023
| @@ -47,7 +47,7 @@ It exposes the following metrics: | |||
| |-|-| | |||
| | `unused_disks_count` | How many unused disks are in this provider | | |||
| | `unused_disks_size_gb` | Total size of unused disks in this provider in GB | | |||
| | `unused_provider_duration_ms` | How long in milliseconds took to fetch this provider information | | |||
| | `unused_provider_duration_ms` | How long in microseconds took to fetch this provider information | | |||
There was a problem hiding this comment.
This just made me realize something: ms is globally understood as milliseconds, but now we're using microseconds (I missed this change), so I think we should change it to us instead 🤔 (µs would be more correct and Prometheus support UTF-8 if I'm not mistaken but that would be too much).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.