-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix getRegionFromZone(), add exporter_test.go #94
Conversation
Signed-off-by: JuanJo Ciarlante <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tested the changes to the makefile on my machine too, and it seems to be compatible with my docker setup too.
Co-authored-by: Leandro López <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Co-authored-by: Leandro López <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
Signed-off-by: JuanJo Ciarlante <[email protected]>
About to merge, built and verified running ok (and scraping
|
built from |
Changes overview:
exporter.go
:getRegionFromZone()
, also make other functions use<provider>.ProviderName
recently added (instead of fixed strings)exporter_test.go
:Dockerfile
:--load
toDockerfile
to support buildx setups.--
Signed-off-by: JuanJo Ciarlante [email protected]