Add --stop-on-failed-ci #441
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dblinkhorn
reviewed
Dec 11, 2025
| ), | ||
| }, | ||
| &cli.BoolFlag{ | ||
| Name: "stop-on-failed-ci", |
Contributor
There was a problem hiding this comment.
I think this would be more clear if the flag were named something like continue-on-failed-ci or ignore-failed-ci which would default to false to preserve the existing behavior.
dblinkhorn
reviewed
Dec 11, 2025
| Closed: true, | ||
| CIStatus: github.CIStatusFailed, | ||
| }, | ||
| allowFailedCI: true, |
Contributor
There was a problem hiding this comment.
Instead of using a test-only field here, I think it makes more sense to directly set the prConfig field for the test scenario:
Suggested change
| allowFailedCI: true, | |
| continueOnFailedCI: false, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A failed CI doesn't necessarily mean the PR won't get merged. CI could be retried, or it could be non-blocking.
Add a
--stop-on-failed-ciflag to skip the CI check, and rely only on the merged or closed status. Defaults to true for backwards-compatibility.