Skip to content

Combine output #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Combine output #33

wants to merge 8 commits into from

Conversation

mark-00
Copy link
Contributor

@mark-00 mark-00 commented Apr 9, 2025

Add option combined_output to combine stdout and stderr in output

@mark-00 mark-00 requested a review from a team as a code owner April 9, 2025 09:19
@mark-00 mark-00 requested review from szkiba and removed request for a team April 9, 2025 09:19
@andrewslotin andrewslotin reopened this Apr 16, 2025
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pablochacin pablochacin requested review from pablochacin and removed request for szkiba April 25, 2025 13:28
@pablochacin
Copy link
Contributor

@mark-00 thanks for the contribution. After #31 was merged, you need to rebase this PR.

Also, I think the description is not correct, as the PR maintains the normal behavior but adds a new option to return the combined output. Plase update it.

@mark-00
Copy link
Contributor Author

mark-00 commented Apr 25, 2025

@mark-00 thanks for the contribution. After #31 was merged, you need to rebase this PR.

Also, I think the description is not correct, as the PR maintains the normal behavior but adds a new option to return the combined output. Plase update it.

done

Copy link
Contributor

@pablochacin pablochacin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some minor suggestions to make the option's name consistent with the other options.

@mark-00
Copy link
Contributor Author

mark-00 commented May 5, 2025

I did some minor suggestions to make the option's name consistent with the other options.

I commited the suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants