-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback build details project #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnsh
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherry-picking @rxbchen and @chrisshino 's work in Shopify#16 onto the current
grafeas/voucher
: I rangit cherry-pick dab0b6902f2542ada0f6cede2c962866c5d7b1ef^..0935f52c7f2c0f735d9c102b136ff9b1c476a4cc
, then biased towards "incoming changes" to resolve conflicts.In #47 (comment) , Shopify made a nasty hack and forked Voucher to avoid polluting upstream. We'd like to finish that work correctly, so this is part of the housekeeping to bring the branches closer.
What?
Added a new configuration that allows user to configure a fallback project for when build metadata is not found in the same project as the image.
Why?
This addresses the issue where an image and it's corresponding build metadata lives in different GCP projects causing excessive warning logs to be emitted
How?
This is done by adding a configuration:
If this field is not empty, we will attempt to get image build metadata from there when any error occurs
Checklist
Before Merging