Fix return type of simplifyParsedResolveInfoFragmentWithType #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify type as `ResolveTree` for returned `fields` in `simplifyParsedResolveInfoFragmentWithType`. Otherwise, the return type is simply `{}` which is not indexable in TS.
benjie
reviewed
Jun 11, 2025
| @@ -352,7 +352,7 @@ export function simplifyParsedResolveInfoFragmentWithType( | |||
| type: GraphQLType | |||
| ) { | |||
| const { fieldsByTypeName } = parsedResolveInfoFragment; | |||
| const fields = {}; | |||
| const fields: ResolveTree = {}; | |||
There was a problem hiding this comment.
src/index.ts:355:9 - error TS2739: Type '{}' is missing the following properties from type 'ResolveTree': name, alias, args, fieldsByTypeName
355 const fields: ResolveTree = {};
|
Sorry about that – I didn't see that tests fail when I initially submitted this PR. I've now changed the syntax to allow for treating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specify type as
ResolveTreefor returnedfieldsinsimplifyParsedResolveInfoFragmentWithType. Otherwise, the return type is simply{}which is not indexable in TS.Checklist
yarn lint:fixpasses.yarn testpasses.RELEASE_NOTES.mdfile (if one exists).