Fix incorrect lexing and parsing of multi-byte comments #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm realizing this addresses the same bug as this PR: #605 |
|
...I'm going to close this in favor of the other PR, which also addresses multi-byte character sequences in non-comment ranges (e.g. a BOM character) in addition to the comments bug. It also passes the tests I'd added here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently ran into a bug where including the unicode em-dash character (
—) lead to GraphQL queries with that character in the comments to fail to be parsed. Digging into the issue further, it looks like some of the existing handling for lexing comment strings as whitespace fail to account for multi-byte comments in how they count byte length of commented unicode characters.This PR fixes the bug (by including the byte length of commented characters in the "runePosition" count that's used to fast forward whitespace), and adds a couple of tests in the
lexerandparserpackages which should illustrate the bug as it stands onmain.