Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate against @stream on different instances of the same field #4342

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Validate against @stream on different instances of the same field #4342

merged 1 commit into from
Feb 12, 2025
+46 −27

Conversation

robrichard
Copy link
Contributor

@robrichard robrichard requested a review from a team as a code owner February 7, 2025 20:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

Hi @robrichard, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@robrichard robrichard force-pushed the robrichard/validate-stream branch from 8dc826b to fa763b1 Compare February 7, 2025 20:25
yaacovCR
yaacovCR reviewed Feb 9, 2025
View reviewed changes
Copy link
Contributor

@yaacovCR yaacovCR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one small error message suggestion, otherwise looks good.

src/validation/rules/OverlappingFieldsCanBeMergedRule.ts Outdated Show resolved Hide resolved
@robrichard robrichard force-pushed the robrichard/validate-stream branch from fa763b1 to c4532e9 Compare February 10, 2025 14:23
@JoviDeCroock JoviDeCroock added the PR: breaking change 💥 implementation requires increase of "major" version number label Feb 12, 2025
@yaacovCR yaacovCR merged commit 72c9044 into main Feb 12, 2025
29 checks passed
@yaacovCR yaacovCR deleted the robrichard/validate-stream branch February 12, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacovCR yaacovCR yaacovCR left review comments

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robrichard @yaacovCR @JoviDeCroock