Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fish shell completion for tsh #8994

Closed
wants to merge 2 commits into from

Conversation

SMillerDev
Copy link

@SMillerDev SMillerDev commented Nov 15, 2021

This adds some basic shell completion for tsh, mostly for tsh ssh suggesting clusters/nodes and tsh ls suggesting labels.

Related: #3753, #6933, #7170

@github-actions github-actions bot requested review from r0mant and russjones November 15, 2021 14:11
@russjones russjones requested review from codingllama and removed request for r0mant December 8, 2021 22:12
@russjones
Copy link
Contributor

@codingllama You're a fish user right? Do you mind taking a look?

@SMillerDev
Copy link
Author

Fixed some issues I had with scp not completing files correctly

@russjones
Copy link
Contributor

@SMillerDev Thank you for the contribution. Unfortunately we won't be able to merge.

The CLI flag parsing library we use kingpin supports generation of full autocompletion scripts for bash and zsh. We recently enabled that for tsh.

If we add this, we would have two different ways to consume autocompletion and they would be in differing states of completeness. It would be difficult to document and confusing for users. In the face of that, I think it's better we not merge.

There is a issue in the kingpin to add support for fish. Once that is implemented, it should be a simple version bump to add fish autocompletion to tsh.

@russjones russjones closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants