feat(code-block): support line numbers in code blocks #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Preview is ready. |
Contributor
|
Visual Tests Report is ready. |
ZothOmmog
force-pushed
the
code-block-show-line-numbers-outer-html
branch
from
e9ced82 to
25a1ae6
Compare
ZothOmmog
changed the title
ZothOmmog
force-pushed
the
code-block-show-line-numbers-outer-html
branch
3 times, most recently
from
c02bc1e to
31c53f6
Compare
ZothOmmog
force-pushed
the
code-block-show-line-numbers-outer-html
branch
from
31c53f6 to
b8233d1
Compare
ZothOmmog
commented
Nov 18, 2025
| getAttrs: (tok) => { | ||
| return { | ||
| [CodeBlockNodeAttr.Line]: tok.attrGet('data-line'), | ||
| [CodeBlockNodeAttr.ShowLineNumbers]: tok.info.includes('showLineNumbers') |
Author
There was a problem hiding this comment.
This change exists to render this markup without line numbers
line 1
line 2
line 3
Not sure, maybe it should be like this because indented code doesn't have attr showLineNumbers
[CodeBlockNodeAttr.ShowLineNumbers]: ''
631b6b3 to
0c68ddc
Compare
ZothOmmog
force-pushed
the
code-block-show-line-numbers-outer-html
branch
from
0c68ddc to
d214ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #835
This PR adds the ability to display line numbers in code blocks. Users can now toggle line numbers visibility through a checkbox in the code block toolbar.