chore: fix Accordion storybook #2516
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostyaAvtushko
force-pushed
the
fix_accordion_story
branch
from
21bcfbe to
aaa6c29
Compare
Contributor
|
🎭 Component Tests Report is ready. |
KostyaAvtushko
force-pushed
the
fix_accordion_story
branch
from
aaa6c29 to
f970421
Compare
Contributor
Author
|
related to #2514 |
KostyaAvtushko
force-pushed
the
fix_accordion_story
branch
2 times, most recently
from
fb10f7f to
47947be
Compare
Contributor
|
Preview is ready. |
Contributor
|
🎭 Component Tests Report is ready. |
KostyaAvtushko
requested review from
ValeraS,
amje and
korvin89
as code owners
korvin89
approved these changes
Dec 3, 2025
KostyaAvtushko
force-pushed
the
fix_accordion_story
branch
from
47947be to
a92dfcb
Compare
amje
requested changes
Dec 3, 2025
Contributor
amje
left a comment
amje
left a comment
There was a problem hiding this comment.
This breaks plenty of Storybook controls. See Button stories for example
KostyaAvtushko
force-pushed
the
fix_accordion_story
branch
from
a92dfcb to
3af3e59
Compare
Contributor
Author
So, seems like fixed version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After react-docgen-typescript there was in an issue with duplicated items inside Accordion. The package looks a little bit outdated if you check the versions of its deps and it does not look like a package that has good support by maintainers. So, I think we can try to switch to react-docgen(it also supports TypeScript as far as I understand) which is supported by reactjs team, and does not cause problems with Accordion's story