-
-
Notifications
You must be signed in to change notification settings - Fork 33
feat(dgeni): generate color palettes and render in design-land #2912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat(dgeni): generate color palettes and render in design-land #2912
Conversation
@xelaint the styling in the design land color component definitely needs some work. I think what I have sufficiently demonstrates how to use the data available though so hopefully you can take it from here |
@griest024 is this PR dependent on #2909 ? |
Yes |
cf7d6b8
to
af59e88
Compare
@griest024 can we remove |
apps/design-land/src/app/foundations/color/color.component.html
Outdated
Show resolved
Hide resolved
will do, should any single colors ever be part of the generation or only the palettes that contain multiple shades? |
I just went ahead and only gened shaded palettes since the implementation is much cleaner |
@@ -124,3 +124,18 @@ <h2>Decorative palettes</h2> | |||
<div style="background-color: #07230d;"><span class="dl-color__hex">100</span><span class="dl-color__hue">#07230d</span></div> | |||
</div> | |||
</div> | |||
|
|||
<h2>Autogenerated palettes</h2> | |||
<div class="dl-color__decorative-grid"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be moved into its own component in docs-components
and added to the /libs/design/guides/color.md
readme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I moved it but the styles are kinda messed up, can you take a look?
@griest024 does this need to be reworked based on the changes Damien made in the last few weeks? |
@xelaint yes but afaik those changes aren't all merged yet so I will wait until they are to rebase this. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #2905
What is the new behavior?
moves lots of docs stuff to
@daffodil/documentation
to allow design land to access it tooDoes this PR introduce a breaking change?
Other information