Skip to content

#157 add Menu drawer on documentation website #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2018
Merged

#157 add Menu drawer on documentation website #158

merged 5 commits into from
Aug 27, 2018

Conversation

benjaminbours
Copy link
Contributor

#157 First version with fake links. I'm waiting for feedback about the best way to create the sandboxes.

@coveralls
Copy link

coveralls commented Aug 23, 2018

Coverage Status

Coverage remained the same at 78.478% when pulling 98c288d on benjaminbours:feature/doc-menu into 39c581b on gregnb:master.

@gregnb
Copy link
Owner

gregnb commented Aug 23, 2018

Ok, this is great work man. Thank you. Let me look at some other doc example sites and figure out how to proceed with this. We'll keep this PR up as WIP

@gregnb
Copy link
Owner

gregnb commented Aug 26, 2018

@benjaminbours Some Examples you can fill in for now:

Custom Component: https://codesandbox.io/s/xrvrzryjvp
Customize Columns: https://codesandbox.io/s/xowj5oj8w
Custom Footer: https://codesandbox.io/s/5z0w0w9jyk
Customize Styling: https://codesandbox.io/s/0ylq1lqwp0
Custom Toolbar: https://codesandbox.io/s/wy2rl1nyzl
Custom ToolbarSelect: https://codesandbox.io/s/545ym5ov6p
Resizable Columns: https://codesandbox.io/s/q8w3230qpj

I think we should make them embed views what do you think? https://codesandbox.io/embed/q8w3230qpj?autoresize=1&hidenavigation=1

@benjaminbours
Copy link
Contributor Author

Yes It's a nice presentation, good idea 👍

@gregnb
Copy link
Owner

gregnb commented Aug 27, 2018

Soon as the conflicts are resolved I'll look to merge this. Thanks for help again!

@benjaminbours
Copy link
Contributor Author

My god, I realy sucked with the package-lock.json, I will never remove it again from a repo ! :p

@gregnb gregnb merged commit 193b7ee into gregnb:master Aug 27, 2018
@gregnb
Copy link
Owner

gregnb commented Aug 27, 2018

No worries. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants