chore: migrate knowledge dataclasses to Pydantic — 17 classes, -285 LOC (AC-489, AC-481)#595
Merged
jayscambler merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
…C-481) Converted ~17 dataclasses across 8 knowledge files from @DataClass to Pydantic BaseModel. Eliminates ~300 lines of hand-rolled to_dict/from_dict. Files: hint_volume.py, mutation_log.py, lessons.py, evidence_freshness.py, research_hub.py, weakness.py, progress.py, normalized_metrics.py Also fixed: - mutation_log.py: __post_init__ → model_post_init for auto-timestamp - lessons.py: __post_init__ → model_post_init for last_validated_gen default - HintManager: kept custom to_dict (accesses private state, not a BaseModel) - 1 test file: positional args → keyword args 9 files changed, 81 insertions, 366 deletions (-285 net)
This was referenced Mar 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch migration of ~17 knowledge module dataclasses to Pydantic BaseModel, continuing the pattern from analytics (#593, #594).
Changes
8 files converted, -285 LOC net:
research_hub.pynormalized_metrics.pylessons.pyweakness.pyhint_volume.pyevidence_freshness.pymutation_log.pyprogress.pySpecial cases handled
mutation_log.py:__post_init__→model_post_initfor auto-timestamp populationlessons.py:__post_init__→model_post_initforlast_validated_gendefaultHintManager: kept as plain class (not a dataclass, accesses private state)Verification
ruff check src— all checks passedmypy src— zero errorspytest tests/— all tests passIssues
Continues AC-489 and AC-481 (analytics + knowledge done, harness/other modules to follow)