Skip to content

Pin the launch runtime in TUI docker-gate tests #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkonopelski-gd merged 1 commit into from
Jul 30, 2026
Merged

Pin the launch runtime in TUI docker-gate tests #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 33 additions & 3 deletions mcp_server/tests/test_tui_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,24 @@ def _gate_ready():
)


def _docker_runtime():
"""Pin the launch runtime to docker, explicitly configured rather than inferred.

The gate branches on the runtime (docker → StartContainersScreen, process →
StartBackendProcessScreen), so container-path tests must pin it: otherwise they read
the developer's own BACKEND_RUNTIME/saved choice and assert the wrong branch. Marking
it configured also skips the infer-from-what's-running block, which would consult the
real host for a backend process.
"""
return (
patch("tui.app.backend_runtime_is_configured", return_value=True),
patch(
"tui.app.resolve_backend_runtime",
return_value=tui_app.local_env.BackendRuntime.DOCKER,
),
)


class TestStartupGate:
@pytest.mark.asyncio
async def test_ready_gen_lands_on_dashboard(self):
Expand Down Expand Up @@ -408,9 +426,11 @@ async def test_client_setup_skip_proceeds_to_sessions(self):

@pytest.mark.asyncio
async def test_containers_down_prompts_start(self):
cfg, rt = _docker_runtime()
with (
cfg,
rt,
patch("tui.app.local_env.is_setup_complete", return_value=True),
patch("tui.app.backend_runtime_is_configured", return_value=True),
patch("tui.app.local_env.containers_running", return_value=False),
):
app = tui_app.SpecFlowTUI(root=Path("/tmp/x"), generation_id=None, poll_interval=999)
Expand All @@ -420,9 +440,11 @@ async def test_containers_down_prompts_start(self):

@pytest.mark.asyncio
async def test_start_no_quits_app(self):
cfg, rt = _docker_runtime()
with (
cfg,
rt,
patch("tui.app.local_env.is_setup_complete", return_value=True),
patch("tui.app.backend_runtime_is_configured", return_value=True),
patch("tui.app.local_env.containers_running", return_value=False),
):
app = tui_app.SpecFlowTUI(root=Path("/tmp/x"), generation_id=None, poll_interval=999)
Expand All @@ -434,9 +456,11 @@ async def test_start_no_quits_app(self):

@pytest.mark.asyncio
async def test_start_yes_starts_then_proceeds(self):
cfg, rt = _docker_runtime()
with (
cfg,
rt,
patch("tui.app.local_env.is_setup_complete", return_value=True),
patch("tui.app.backend_runtime_is_configured", return_value=True),
patch("tui.app.local_env.containers_running", return_value=False),
patch("tui.app.local_env.start_containers", new=AsyncMock(return_value=0)),
patch("tui.app.local_env.wait_backend_ready", new=AsyncMock(return_value=True)),
Expand All @@ -454,7 +478,10 @@ async def test_start_yes_starts_then_proceeds(self):
async def test_containers_up_but_backend_not_ready_says_unhealthy_not_down(self):
# Containers running + backend not ready → the gate must not claim the
# containers aren't running; it shows the "backend isn't healthy" prompt.
cfg, rt = _docker_runtime()
with (
cfg,
rt,
patch("tui.app.local_env.is_setup_complete", return_value=True),
patch("tui.app.local_env.containers_running", return_value=True),
patch("tui.app.local_env.backend_ready", new=AsyncMock(return_value=False)),
Expand All @@ -476,7 +503,10 @@ async def test_backend_not_ready_retry_skips_compose_up(self):
# In the up-but-not-ready path, retrying (y) re-polls readiness without
# re-running `docker compose up` (the containers are already up).
start = AsyncMock(return_value=0)
cfg, rt = _docker_runtime()
with (
cfg,
rt,
patch("tui.app.local_env.is_setup_complete", return_value=True),
patch("tui.app.local_env.containers_running", return_value=True),
patch("tui.app.local_env.backend_ready", new=AsyncMock(return_value=False)),
Expand Down