Add the possibility to evaluate a filter and restrict the result to specified equipment types #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DTOs (`FiltersWithEquipmentTypes`, `EquipmentTypesByElement`) to handle filters and equipment types Signed-off-by: Florent MILLOT <[email protected]>
… of throwing an exception. Signed-off-by: Florent MILLOT <[email protected]>
…y for substation/voltage level equipment filtering Signed-off-by: Florent MILLOT <[email protected]>
basseche
reviewed
Oct 10, 2025
src/main/java/org/gridsuite/filter/server/utils/FilterWithEquipmentTypesUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/server/utils/FilterWithEquipmentTypesUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/filter/server/utils/FilterWithEquipmentTypesUtils.java
Outdated
Show resolved
Hide resolved
… explicit field-specific methods. Updated copyright year. Signed-off-by: Florent MILLOT <[email protected]>
EtienneLt
reviewed
Oct 13, 2025
src/main/java/org/gridsuite/filter/server/dto/EquipmentTypesByFilterId.java
Show resolved
Hide resolved
… coverage Signed-off-by: Florent MILLOT <[email protected]>
|
Remarks fixed and tests added |
EtienneLt
reviewed
Oct 13, 2025
src/test/java/org/gridsuite/filter/server/utils/FilterWithEquipmentTypesUtilsTest.java
Show resolved
Hide resolved
Signed-off-by: Florent MILLOT <[email protected]>
… class Signed-off-by: Florent MILLOT <[email protected]>
…earer semantics and update references accordingly. Signed-off-by: Florent MILLOT <[email protected]>
…s documentation Signed-off-by: Florent MILLOT <[email protected]>
EtienneLt
reviewed
Oct 15, 2025
src/main/java/org/gridsuite/filter/server/dto/FiltersWithEquipmentTypes.java
Show resolved
Hide resolved
|
you have sonar issue at least one can be resolved (switch instead of if) |
…or improved readability and reduced duplication Signed-off-by: Florent MILLOT <[email protected]>
Done, the other one is a false one because we are already in transactional function |
thangqp
approved these changes
Oct 15, 2025
Signed-off-by: Florent MILLOT <[email protected]>
thangqp
reviewed
Oct 17, 2025
| List<ExpertFilter> filters = FilterWithEquipmentTypesUtils.createFiltersForSubEquipments(filterEquipmentType, | ||
| filteredEquipmentIds, | ||
| selectedEquipmentTypes); | ||
| filters.stream().flatMap(expertFilter -> evaluateFilter(expertFilter, networkUuid, variantId).stream()) |
There was a problem hiding this comment.
Sonar high level while using @transactional method evaluateFilter()
=> you can try to use directly getIdentifiableAttributes
…tion in `FilterService`. Signed-off-by: Florent MILLOT <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored filter evaluation API: switched to POST method, added new DTOs (
FiltersWithEquipmentTypes,EquipmentTypesByElement) to handle filters and equipment types