Fix out of substation voltage level should not hinder geo search #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurgarn
force-pushed
the
fix_out_of_substation_voltage_level_should_not_hinder_geo_search
branch
from
8d05daa to
a0096b7
Compare
laurgarn
requested review from
ghazwarhili and
FranckLecuyer
and removed request for
ghazwarhili
FranckLecuyer
requested changes
Jun 2, 2025
| mapSubstationsByLine.entrySet().stream() | ||
| .filter(entry -> entry.getValue() != null) | ||
| .filter(entry -> entry.getValue().getLeft() != null) | ||
| .filter(entry -> entry.getValue().getRight() != null) |
There was a problem hiding this comment.
Only one filter call instead of 3 ?
There was a problem hiding this comment.
I see it clearer that way. Do you think it could have a noticeable influence on performance ?
src/test/java/org/gridsuite/geodata/server/GeoDataServiceTest.java
Outdated
Show resolved
Hide resolved
|
Substations and LinePositions are returned in a reasonable time but some 73 substations can not be assigned coordinates, as for many lines. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A search for lines geo-data currently raises an exception as part of the code assumes
This pull request adds a test for an adverse case and a fix for this case