Add new contingency list by filter #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basseche
changed the title
Signed-off-by: basseche <[email protected]>
Signed-off-by: basseche <[email protected]>
Signed-off-by: basseche <[email protected]>
basseche
changed the title
flomillot
previously requested changes
Sep 18, 2025
src/components/dialogs/contingency-list/creation/contingency-list-creation-form.tsx
Show resolved
Hide resolved
src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-dialog.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-form.tsx
Show resolved
Hide resolved
|
|
||
| const equipmentTypes: string[] = useMemo(() => { | ||
| return [ | ||
| EquipmentType.TWO_WINDINGS_TRANSFORMER, |
There was a problem hiding this comment.
À propos de EquipmentType
Deprecated:
move to a specialized subtype as this one is used everywhere and cause problems
There was a problem hiding this comment.
Oui je sais. Mais ça n'a pas de sens de mettre deprecated alors qu'il n'y a pas d’alternative. Du coup, il a été décidé, après un daily, d'enlever ce deprecated.
There was a problem hiding this comment.
Ah ok je savais pas, il faudrait peut etre l'enlever du coup...
There was a problem hiding this comment.
This is a literal object => extract to outside of component but in the same file
src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-from.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-from.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-from.tsx
Outdated
Show resolved
Hide resolved
flomillot
reviewed
Sep 22, 2025
src/components/dialogs/contingency-list/filter-based/separator-cell-renderer.tsx
Outdated
Show resolved
Hide resolved
|
Text not centered in the Chips 
|
thangqp
reviewed
Sep 23, 2025
src/components/dialogs/contingency-list/filter-based/separator-cell-renderer.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| const equipmentTypes: string[] = useMemo(() => { | ||
| return [ | ||
| EquipmentType.TWO_WINDINGS_TRANSFORMER, |
There was a problem hiding this comment.
This is a literal object => extract to outside of component but in the same file
src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-form.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/contingency-list/filter-based/contingency-list-filter-based-dialog.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Thang PHAM <[email protected]>
Co-authored-by: Thang PHAM <[email protected]>
Signed-off-by: Thang PHAM <[email protected]>
thangqp
reviewed
Sep 24, 2025
thangqp
approved these changes
Sep 24, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs changes from commons-ui to compile :
gridsuite/commons-ui#839