Skip to content

Add limits properties components in Line and two windings transformer dialogs #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add limits properties components in Line and two windings transformer dialogs #3407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a9c957
Activate property modification on line and two windings transformers …
basseche Oct 30, 2025
5878b97
Merge branch 'main' into limitsProperties_modification
basseche Nov 3, 2025
edd09c7
remove unused prop in limits-side-pane
basseche Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/dialogs/limits/limits-pane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ export function LimitsPane({
selectedLimitSetName={operationalLimitsGroup.name}
checkLimitSetUnicity={checkLimitSetUnicity}
disabled={!olgEditable}
isModification={isAModification}
/>
)
)}
Expand Down
12 changes: 4 additions & 8 deletions src/components/dialogs/limits/limits-side-pane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export interface LimitsSidePaneProps {
selectedLimitSetName?: string;
checkLimitSetUnicity: (editedLimitGroupName: string, newSelectedApplicability: string) => string;
disabled: boolean;
isModification?: boolean;
}

export function LimitsSidePane({
Expand All @@ -63,7 +62,6 @@ export function LimitsSidePane({
selectedLimitSetName,
checkLimitSetUnicity,
disabled,
isModification,
}: Readonly<LimitsSidePaneProps>) {
const intl = useIntl();
const { setError, getValues } = useFormContext();
Expand Down Expand Up @@ -207,12 +205,10 @@ export function LimitsSidePane({
<Box sx={{ p: 2 }}>
{limitsGroupApplicabilityName && (
<Box>
{!isModification && (
<LimitsPropertiesSideStack
name={`${opLimitsGroupFormName}.${LIMITS_PROPERTIES}`}
disabled={disabled}
/>
)}
<LimitsPropertiesSideStack
name={`${opLimitsGroupFormName}.${LIMITS_PROPERTIES}`}
disabled={disabled}
/>
<Grid container justifyContent="flex-start" alignItems="center" sx={{ paddingBottom: '15px' }}>
<Grid item xs={2}>
<FormattedMessage id="Applicability" />
Expand Down
8 changes: 3 additions & 5 deletions src/components/dialogs/limits/operational-limits-groups-tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,11 +339,9 @@ export const OperationalLimitsGroupsTabs = forwardRef<any, OperationalLimitsGrou
''
)}
</Stack>
{!isAModification && (
<LimitsPropertiesStack
name={`${parentFormName}.${OPERATIONAL_LIMITS_GROUPS}[${index}].${LIMITS_PROPERTIES}`}
/>
)}
<LimitsPropertiesStack
name={`${parentFormName}.${OPERATIONAL_LIMITS_GROUPS}[${index}].${LIMITS_PROPERTIES}`}
/>
</Stack>

{(index === hoveredRowIndex || index === activatedByMenuTabIndex) && (
Expand Down
Loading