refactor(api): drop unused standalone comicinfo.xml parser#218
Conversation
eaa060c to
45f67b2
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
📝 WalkthroughWalkthroughRemoved the public method Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
45f67b2 to
b9eeb23
Compare
b9eeb23 to
04b09e7
Compare
Description
CbxMetadataExtrator.extractFromComicInfoXml()is a public method that is unusedand does not seem to have a planned use.
To reduce the amount of code that needs to churn when integrating nightcompress,
I opted top drop this unused code.
Split off from #113
Linked Issue: Related to #29
Changes
Drops
CbxMetadataExtrator.extractFromComicInfoXml()Summary by CodeRabbit