Skip to content

refactor(api): drop unused standalone comicinfo.xml parser#218

Merged
balazs-szucs merged 1 commit intogrimmory-tools:developfrom
imnotjames:refactor/29/drop-unused-comicinfo-xml-parser
Mar 27, 2026
Merged

refactor(api): drop unused standalone comicinfo.xml parser#218
balazs-szucs merged 1 commit intogrimmory-tools:developfrom
imnotjames:refactor/29/drop-unused-comicinfo-xml-parser

Conversation

@imnotjames
Copy link
Copy Markdown
Contributor

@imnotjames imnotjames commented Mar 26, 2026

Description

CbxMetadataExtrator.extractFromComicInfoXml() is a public method that is unused
and does not seem to have a planned use.

To reduce the amount of code that needs to churn when integrating nightcompress,
I opted top drop this unused code.

Split off from #113

Linked Issue: Related to #29

Changes

Drops CbxMetadataExtrator.extractFromComicInfoXml()

Summary by CodeRabbit

  • Removed Features
    • Standalone ComicInfo.xml-based metadata extraction has been removed; archive-based metadata extraction and cover handling remain unchanged.
  • Tests
    • Unit tests covering standalone ComicInfo.xml parsing and related fallback-title behaviors were removed, reducing coverage for those standalone parsing scenarios.

@imnotjames imnotjames force-pushed the refactor/29/drop-unused-comicinfo-xml-parser branch from eaa060c to 45f67b2 Compare March 26, 2026 06:29
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f8ffc179-6091-453e-821b-6093f6ce8a4f

📥 Commits

Reviewing files that changed from the base of the PR and between b9eeb23 and 04b09e7.

📒 Files selected for processing (2)
  • booklore-api/src/main/java/org/booklore/service/metadata/extractor/CbxMetadataExtractor.java
  • booklore-api/src/test/java/org/booklore/service/metadata/extractor/CbxMetadataExtractorTest.java
💤 Files with no reviewable changes (2)
  • booklore-api/src/main/java/org/booklore/service/metadata/extractor/CbxMetadataExtractor.java
  • booklore-api/src/test/java/org/booklore/service/metadata/extractor/CbxMetadataExtractorTest.java
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Test Suite / Backend Tests
  • GitHub Check: Analyze (java-kotlin)

📝 Walkthrough

Walkthrough

Removed the public method extractFromComicInfoXml(File xmlFile) and its private helper determineFallbackTitle(File file) from CbxMetadataExtractor, and deleted the corresponding nested test suite; archive-based CBx metadata/cover extraction remains unchanged.

Changes

Cohort / File(s) Summary
Extractor implementation
booklore-api/src/main/java/org/booklore/service/metadata/extractor/CbxMetadataExtractor.java
Deleted public extractFromComicInfoXml(File) and its private determineFallbackTitle(File), removing standalone-file ComicInfo.xml parsing/fallback-title logic and its exception-based return path.
Extractor tests
booklore-api/src/test/java/org/booklore/service/metadata/extractor/CbxMetadataExtractorTest.java
Removed the nested ExtractFromComicInfoXml test class (null-input validation, standalone XML parsing assertions, fallback title cases, and malformed/non-existent file behavior tests).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I nudged a method out the door,
ComicInfo alone is needed no more,
Archives keep humming, quiet and neat,
I twitch my nose and dance on my feet,
A tiny hop for code, a carrot to eat.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commit format with 'refactor(api)' prefix and clearly describes the main change of removing unused code.
Description check ✅ Passed The description includes required sections (Description, Linked Issue, Changes) with clear context about why the method is being removed and references to related issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands and usage tips.

@imnotjames imnotjames changed the title refactor: drop unused standalone comicinfo.xml parser refactor(api): drop unused standalone comicinfo.xml parser Mar 26, 2026
@imnotjames imnotjames force-pushed the refactor/29/drop-unused-comicinfo-xml-parser branch from 45f67b2 to b9eeb23 Compare March 26, 2026 16:11
@imnotjames imnotjames force-pushed the refactor/29/drop-unused-comicinfo-xml-parser branch from b9eeb23 to 04b09e7 Compare March 27, 2026 14:54
Copy link
Copy Markdown
Member

@balazs-szucs balazs-szucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@balazs-szucs balazs-szucs merged commit ba42f2f into grimmory-tools:develop Mar 27, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants