Skip to content

refactor(ui): replace SVG artwork placeholders with CSS #292

Draft
alexhb1 wants to merge 2 commits intogrimmory-tools:developfrom
alexhb1:perf-2-icon-placeholder
Draft

refactor(ui): replace SVG artwork placeholders with CSS #292
alexhb1 wants to merge 2 commits intogrimmory-tools:developfrom
alexhb1:perf-2-icon-placeholder

Conversation

@alexhb1
Copy link
Copy Markdown
Contributor

@alexhb1 alexhb1 commented Mar 30, 2026

Description

Currently, books with no artwork use a generated SVG with specific (ugly) styling and has a complex and intensive pipeline for displaying them, especially with large libraries. They're generated on the fly with no storage or caching. This replaces the entire approach with a simplified in-line placeholder div with a bit of basic text and CSS.

Before vs after:
Screenshot 2026-03-30 at 23 35 09 Screenshot 2026-03-30 at 23 40 26

Changes

  • Removes all SVG generating code and plumbing for displaying placeholder images
  • Adds a basic CSS placeholder with title+author and background color

Will mark as ready once my other layout shell rework PR is done and through, this can be sorted afterwards.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c6537e26-65e0-49a0-ba19-da47a5aba1be

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands and usage tips.

@balazs-szucs
Copy link
Copy Markdown
Member

Currently, books with no artwork use a generated SVG with specific (ugly) styling and has a complex and intensive pipeline for displaying them, especially with large libraries

🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants