refactor(ui): replace SVG artwork placeholders with CSS #292
Draft
alexhb1 wants to merge 2 commits intogrimmory-tools:developfrom
Draft
refactor(ui): replace SVG artwork placeholders with CSS #292alexhb1 wants to merge 2 commits intogrimmory-tools:developfrom
alexhb1 wants to merge 2 commits intogrimmory-tools:developfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Member
🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, books with no artwork use a generated SVG with specific (ugly) styling and has a complex and intensive pipeline for displaying them, especially with large libraries. They're generated on the fly with no storage or caching. This replaces the entire approach with a simplified in-line placeholder div with a bit of basic text and CSS.
Before vs after:

Changes
Will mark as ready once my other layout shell rework PR is done and through, this can be sorted afterwards.