Remove misspelled and unneeded padding constant. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constant was intended to be `crypto.constants.RSA_PKCS1_OAEP_PADDING`. Luckily, the misspelling (with "OEAP") caused it to be undefined, and use node-crypto's default, which is already RSA_PKCS1_OAEP_PADDING. The removal makes the reliance on the default explicit. The default is documented at https://nodejs.org/api/crypto.html#cryptopublicencryptkey-buffer. It is already the recommended value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant was intended to be
crypto.constants.RSA_PKCS1_OAEP_PADDING. Luckily, the misspelling (with "OEAP") caused it to be undefined, and use node-crypto's default, which is already RSA_PKCS1_OAEP_PADDING.The removal makes the reliance on the default explicit. The default is documented at https://nodejs.org/api/crypto.html#cryptopublicencryptkey-buffer. It is already the recommended value.