fix: remove report moderation token leak#42
Draft
dduffy-groq wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/reportleak of a tokenized moderation URL.rootUrlfor moderation/report links./api/block.Security Rationale
The old report flow was unauthenticated, loaded the app creator IP, built a
/block?...&token=...URL withBLOCK_SECRET, sent it to Slack, and returned the same URL to the caller. That exposed a privileged moderation token and a destructive block/delete primitive to the reporter.This patch keeps report submission working but removes the tokenized moderation URL from the response and stops client/browser code from invoking destructive block actions through a URL.
Internal Context
Checked Slack, Google Drive, and Notion via authenticated fallbacks. No rationale found for preserving caller-controlled
rootUrl, URL-carriedBLOCK_SECRET, or unauthenticated access to a destructive moderation link.Notion MCP OAuth/login was completed on 2026-07-02. Browser workspace search found
CE-421/Appgen - add LLM check for user abuse reports to reduce false positives, a P2 Backlog Cloud Engineering item. That supports historical AppGen abuse-report false-positive concerns, but not the token-in-URL moderation behavior.Evidence:
evidence/H1-3831804/internal_context.mdLinear: https://linear.app/groq/issue/SEC-32
Validation
git diff --checknpm run test:h1-3831804pnpm lintdid not run because local dependencies are not installed (nextnot found).Follow-Up
Replace the internal
x-block-secretflow with the product's normal admin-authenticated moderation path when that owner/system is available.