Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update payload_interceptors.go #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bradywatkinson
Copy link

Update incorrect logging message in PayloadUnaryServerInterceptor from:
"server response payload logged as grpc.request.content field"
to
"server response payload logged as grpc.response.content field"

Update incorrect logging message in `PayloadUnaryServerInterceptor` from:
`"server response payload logged as grpc.request.content field"`
to
`"server response payload logged as grpc.response.content field"`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@codecov-io
Copy link

Codecov Report

Merging #170 into master will decrease coverage by 0.67%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   73.47%   72.79%   -0.68%     
==========================================
  Files          36       36              
  Lines        1327     1327              
==========================================
- Hits          975      966       -9     
- Misses        303      311       +8     
- Partials       49       50       +1
Impacted Files Coverage Δ
logging/logrus/payload_interceptors.go 84.12% <100%> (ø) ⬆️
retry/retry.go 73.33% <0%> (-5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 498ae20...9090daf. Read the comment docs.

Copy link
Contributor

@domgreen domgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good, but could you make the same change in logging/zap/payload_interceptors.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants