Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset connect backoff #260

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iostrovok
Copy link

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@johanbrandhorst
Copy link
Collaborator

Hi @iostrovok. I think we should discuss whether we want to add this before going straight to implementing it. Reading the documentation for the method, I'm not convinced:

In general, this function should not be used. Typical service or network outages result in a reasonable client reconnection strategy by default.

(https://godoc.org/google.golang.org/grpc#ClientConn.ResetConnectBackoff)

What is your use case that requires adding this?

@yashrsharma44
Copy link
Collaborator

Hi @iostrovok, any updates to this PR?

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.05882% with 19 lines in your changes missing coverage. Please review.

Project coverage is 73.05%. Comparing base (3c51f7f) to head (e18800c).
Report is 203 commits behind head on main.

Files with missing lines Patch % Lines
retry/retry.go 73.21% 10 Missing and 5 partials ⚠️
retry/options.go 66.66% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   73.27%   73.05%   -0.22%     
==========================================
  Files          42       42              
  Lines        1564     1585      +21     
==========================================
+ Hits         1146     1158      +12     
- Misses        365      374       +9     
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants