-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset connect backoff #260
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @iostrovok. I think we should discuss whether we want to add this before going straight to implementing it. Reading the documentation for the method, I'm not convinced:
(https://godoc.org/google.golang.org/grpc#ClientConn.ResetConnectBackoff) What is your use case that requires adding this? |
Hi @iostrovok, any updates to this PR? |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 73.27% 73.05% -0.22%
==========================================
Files 42 42
Lines 1564 1585 +21
==========================================
+ Hits 1146 1158 +12
- Misses 365 374 +9
Partials 53 53 ☔ View full report in Codecov by Sentry. |
support https://godoc.org/google.golang.org/grpc#ClientConn.ResetConnectBackoff