weightedroundrobin: Implements Slow Start (gRFC A100) [WiP] #8689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements slow start functionality as described in [gRFC A100](grpc/proposal#498) I still need to do some work on tests and do an e2e experiment with xDS to ensure that things are working as expected, but the core implementation is in a state that can be reviewed. At this phase I'm mainly looking for feedback on the overall approach and design and in the test code because I am worried that I might be missing some test utility that would make testing with `time` easier. Pending Items before this is ready to be merged: - [ ] Add more unit tests for slow start config cases - [ ] Manually verify with an xDS experiment that slow start is working as expected Release Notes * weightedroundrobin: Implements slow start functionality as described in [gRFC A100](grpc/proposal#498) Signed-off-by: sotiris <[email protected]>
Signed-off-by: sotiris <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8689 +/- ##
==========================================
- Coverage 83.43% 83.32% -0.12%
==========================================
Files 415 416 +1
Lines 32195 32342 +147
==========================================
+ Hits 26863 26949 +86
- Misses 3980 4016 +36
- Partials 1352 1377 +25
🚀 New features to boost your workflow:
|
davinci26
commented
Nov 1, 2025
go.mod
Outdated
| github.com/envoyproxy/go-control-plane/envoy v1.35.0 | ||
| github.com/cncf/xds/go v0.0.0-20251014123835-2ee22ca58382 | ||
| github.com/envoyproxy/go-control-plane v0.13.4 | ||
| github.com/envoyproxy/go-control-plane/envoy v1.35.1-0.20251015221300-4138018a492b |
Contributor
Author
There was a problem hiding this comment.
imports a commit because the proto is not in a release yet, validate this is the correct version for all deps
Signed-off-by: sotiris <[email protected]>
Signed-off-by: sotiris <[email protected]>
Signed-off-by: sotiris <[email protected]>
Contributor
Author
|
Don't want to commit this code because it introduces a new dependencies but wanted to make sure the 
(Note the flatline at start is due to |
Signed-off-by: sotiris <[email protected]>
Signed-off-by: sotiris <[email protected]>
Signed-off-by: sotiris <[email protected]>
Signed-off-by: sotiris <[email protected]>
davinci26
changed the title
davinci26
commented
Nov 3, 2025
| if slowStartConfigCfg := cswrrProto.GetSlowStartConfig(); slowStartConfigCfg != nil { | ||
| wrrLBCfg.SlowStartConfig = &weightedroundrobin.SlowStartConfig{ | ||
| SlowStartWindow: internalserviceconfig.Duration(slowStartConfigCfg.GetSlowStartWindow().AsDuration()), | ||
| // SlowStartConfig uses a runtime value in the proto definition so we need to get either the default value or the runtime value |
Contributor
Author
There was a problem hiding this comment.
Wanted to call some attention here since this is a bit of subtle point, where I made a decision but maybe its worth clarifying in the gRFC
Signed-off-by: sotiris <[email protected]>
Signed-off-by: sotiris <[email protected]>
davinci26
commented
Nov 10, 2025
| ew.stopORCAListener() | ||
| } | ||
| ew.mu.Lock() | ||
| ew.readySince = time.Time{} // Reset readySince when going non-READY. |
Contributor
Author
There was a problem hiding this comment.
The implementation should be adjusted based on the convo grpc/proposal#498 (comment)
Contributor
|
Apologies for the delay in reviewing this PR. I'm starting on this today and hopefully will have comments soon. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements slow start functionality as described in gRFC A100
I still need to do some work on tests and do an e2e experiment with xDS to ensure that things are working as expected, but the core implementation is in a state that can be reviewed.
At this phase I'm mainly looking for feedback on the overall approach and design and in the test code because I am worried that I might be missing some test utility that would make testing with
timeeasier.Pending Items before this is ready to be merged:
RELEASE NOTES: