Skip to content

Conversation

@mbissa
Copy link
Contributor

@mbissa mbissa commented Nov 11, 2025

Addresses :

This PR makes available backend service (cluster name) label which is decided in clusterimpl (since we are pre-A75). It is added to weighted round robin per call metrics.
Also, this PR adds sub channel metrics which will eventually replace the pick first metrics.

RELEASE NOTES:

  • stats/otel: add backend service label to wrr metrics and add subchannel metrics to eventually replace the pickfirst metrics

@mbissa mbissa requested a review from easwars November 11, 2025 20:42
@mbissa mbissa added Type: Feature New features or improvements in behavior Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability labels Nov 11, 2025
@mbissa mbissa added this to the 1.78 Release milestone Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.48%. Comparing base (e816736) to head (fba7b07).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8701      +/-   ##
==========================================
+ Coverage   83.29%   83.48%   +0.19%     
==========================================
  Files         416      416              
  Lines       32267    32329      +62     
==========================================
+ Hits        26876    26991     +115     
+ Misses       4017     3972      -45     
+ Partials     1374     1366       -8     
Files with missing lines Coverage Δ
balancer/weightedroundrobin/balancer.go 85.87% <100.00%> (+0.32%) ⬆️
balancer/weightedroundrobin/scheduler.go 96.22% <100.00%> (ø)
clientconn.go 90.46% <100.00%> (+0.08%) ⬆️
internal/testutils/stats/test_metrics_recorder.go 82.69% <100.00%> (+9.08%) ⬆️
internal/transport/http2_client.go 92.62% <100.00%> (+0.20%) ⬆️
internal/transport/transport.go 88.70% <ø> (ø)
internal/xds/balancer/clusterimpl/clusterimpl.go 83.79% <100.00%> (+0.07%) ⬆️
internal/xds/xds.go 80.00% <100.00%> (+5.00%) ⬆️
resolver/resolver.go 100.00% <100.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbissa mbissa removed the request for review from easwars November 11, 2025 20:45
@mbissa mbissa force-pushed the a94-subchannel-metrics-with-labels branch 6 times, most recently from c71309b to 627d2ca Compare November 11, 2025 22:29
@mbissa mbissa force-pushed the a94-subchannel-metrics-with-labels branch from 627d2ca to fba7b07 Compare November 13, 2025 09:15
@dfawley dfawley changed the title stats/otel : add backend service attribute to weighted round robin metrics and add subchannel metrics stats/otel: add backend service attribute to weighted round robin metrics and add subchannel metrics Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability Type: Feature New features or improvements in behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants