Skip to content

Upgrade to protobuf 33.1 #12534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Upgrade to protobuf 33.1 #12534

wants to merge 25 commits into from

Conversation

@kannanjgithub
Copy link
Contributor

@kannanjgithub kannanjgithub commented Nov 24, 2025

No description provided.

@kannanjgithub
Upgrade to protobuf 33.1
e249724
@kannanjgithub
Remove deleting abseil-cpp under protobuf as it doesn't exist anymore…
537d11a 
… in 33.1
@kannanjgithub
Use cpp 17
fde9ebf
@kannanjgithub
Use c++ 17
7879dd5
@kannanjgithub
Try force fetch protobuf deps because of the error "Could NOT find ab…
9888b79 
…sl (missing: absl_DIR)" (https://btx.cloud.google.com/invocations/a22ed88e-4a46-4b41-a306-c6fcd4df73af/targets/grpc%2Fjava%2Fmaster%2Fpresubmit%2Flinux_artifacts;config=default/log)
@kannanjgithub
Remove protobuf_FORCE_FETCH_DEPENDENCIES since it is downloading abse…
7e6fdbf 
…il anyway even without it. Remoe -DABSL_INTERNAL_AT_LEAST_CXX17=-0 since I have used c++17 everywhere and this resolves the linker issue.
@kannanjgithub
Build and install abseil separately before protobuf, in an attempt to…
df7cc5a 
… avoid a different version of aseil getting downloaded from it
@kannanjgithub
Remove unwanted change
43d2478
@kannanjgithub
nit
81e7bc4
@kannanjgithub
Specify CMAKE_PREFIX_PATH because for macos it is using some system i…
392a114 
…nstalled old abseil path for x86_64 and fails saying needed arm64 libs
kannanjgithub and others added 14 commits November 26, 2025 07:30
@kannanjgithub
Install cmake for macos.
1bd2197
@kannanjgithub
Download specific cmake version as binary executable for macOS.
0f72994
@kannanjgithub
Turn off errorProne to check if the rest of the build works for macOs
1f05de3
@kannanjgithub
Install jdk 1.8 because it uses JDK 24 and fails build due to incompa…
f339cbe 
…tibility with errorProne 2.31
@kannanjgithub
Revert back to errorProne=true now that the JDK to use has been downg…
8bae81b 
…raded from 24.0 to 1.8
@kannanjgithub
Install maven for macOS
5999423
@kannanjgithub
Set ARCH to aarch_64 for macOs.
e866102
@kannanjgithub
Swap aarch and x86 copying for macOS in upload_artifacts.sh
c9469d6
@kannanjgithub
Try setting JAVA_HOME to make maven use the correct x86 jdk
815c2ec
@kannanjgithub
Add debug flag to build gradle
474e39a
@kannanjgithub
Remove debug flag as it is not helping, just adding noise
fa6760d
@kannanjgithub
Remove ARCH to make it x86_64 throughout.
ac61486
@kannanjgithub
Remove setting JAVA_HOME, made no difference.
7e78b9d
@kannanjgithub
Revert "Remove setting JAVA_HOME, made no difference."
19a3f83 
This reverts commit 7e78b9d.
@kannanjgithub
Copy link
Contributor Author

kannanjgithub commented Dec 2, 2025

macOS build triggered on sonoma-slcn aarch pool: http://sponge2/76632cca-8a8d-4b72-8315-076f0e55748d

@kannanjgithub kannanjgithub marked this pull request as ready for review December 2, 2025 11:10
@kannanjgithub kannanjgithub requested a review from ejona86 December 2, 2025 11:10
ejona86
ejona86 reviewed Dec 2, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kannanjgithub @ejona86