Skip to content

[Deps] Update google_benchmark to v1.9.2 #39058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

UebelAndre
Copy link

Upgrades google_benchmark/com_github_google_benchmark to v1.9.2 to avoid the Bazel issue bazelbuild/bazel#24871

Copy link

linux-foundation-easycla bot commented Mar 25, 2025

CLA Not Signed

@UebelAndre UebelAndre changed the title Update google_benchmark to v1.9.2 [Deps] Update google_benchmark to v1.9.2 Mar 25, 2025
@UebelAndre
Copy link
Author

CLA Not Signed

* [❌](https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/1656153/27729880/39058/#/?version=2) - login: @UebelAndre . The commit ([252cb1d](https://github.com/grpc/grpc/commit/252cb1d2c9a4444affe2c8e314f052a15fe8a690)) is not authorized under a signed CLA. [Please click here to be authorized](https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/1656153/27729880/39058/#/?version=2). For further assistance with EasyCLA, [please submit a support request ticket](https://jira.linuxfoundation.org/servicedesk/customer/portal/4).

I currently don't have time to read through this CLA. Seems really intense. Hopefully someone can take the changes at some point over the finishline.

@UebelAndre
Copy link
Author

This is also less urgent since google_benchmark is now dev_dependency = True so shouldn't affect external consumers.

@drfloob
Copy link
Member

drfloob commented Mar 25, 2025

Thanks @UebelAndre . If you don't sign the CLA, then we can't evaluate (or work off of) your contribution. The benchmark dependency is updated as needed, as you said there's usually no great urgency in it.

@UebelAndre
Copy link
Author

Thanks @UebelAndre . If you don't sign the CLA, then we can't evaluate (or work off of) your contribution. The benchmark dependency is updated as needed, as you said there's usually no great urgency in it.

Does this mean it I don’t sign no one can update google_benchmark?

@drfloob
Copy link
Member

drfloob commented Mar 25, 2025

The third party library update processes are straightforward and documented.

I'll go ahead and close this PR. Feel free to reopen it if you'd like to contribute!

@drfloob drfloob closed this Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants