Remove dependence on old version of the qrcode-generator library and streamline the development artifacts and external API #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Cleaned up package.json manifest - Pinned development packages to current latest versions - Split "test" script in package.json into "test" and "example" - Added yarn.lock file
|
@gtanner, would you please consider merging this? |
|
@mwbrooks, would you please take a look at this pull request? |
|
@gtanner, I hate to bug you but... |
|
Please someone merge this!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes aims to bring this project up to date with latest upstream developments, along with proper versioning of the declared dependencies and a switch to
yarntooling.The dependence on an outdated version of kazuhikoarase/qrcode-generator has become an impedance to further development of this utility and equivalent or better ASCII rendering functionality is now part of the upstream library, and so this PR removes its implementation from the source code of this project and sets up a dependence on the latest upstream version of qrcode-generator.
Also, this PR fixes the unit tests and makes some small but material changes to the external API.
In terms of further development, it looks valuable to incorporate the ability to set the data mode, code type, and error correction level both when calling the node API and also when invoking this utility from the command line.